Hi Jiacai, I appreciate and am thankful of your willingness to improve the library, however I find that the proposed changes bring mostly more concision at the expense of readability, a tradeoff which I don't find beneficial in this case. In particular, the use of explicit parameter names and certain indentation strategies were by design for readability. Granted, this is largely a matter of personal taste, but being the lead maintainer I'd rather we stick to my subjective preferences for these choices, especially when they don't violate any Clojure convention for code style.
So I'm closing the PR now, thanks again and I hope this won't deter you from offering further contributions :) don't hesitate to reach out to me for discussion before investing your time in code.
Hi Jiacai, I appreciate and am thankful of your willingness to improve the library, however I find that the proposed changes bring mostly more concision at the expense of readability, a tradeoff which I don't find beneficial in this case. In particular, the use of explicit parameter names and certain indentation strategies were by design for readability. Granted, this is largely a matter of personal taste, but being the lead maintainer I'd rather we stick to my subjective preferences for these choices, especially when they don't violate any Clojure convention for code style.
So I'm closing the PR now, thanks again and I hope this won't deter you from offering further contributions :) don't hesitate to reach out to me for discussion before investing your time in code.