search

vweevers / hallmark

Markdown Style Guide, with linter and automatic fixer.
GNU General Public License v3.0
30 stars 3 forks source link

Compatibility with markdown-it extensions #87

Closed addshore closed 2 months ago

addshore commented 2 years ago

It would be great to have some compatibility with markdown-it extensions.

Perhaps this only happens in a few cases, in which case I'll rename this issue.

While making use of https://github.com/tatsy/markdown-it-imsize which allows extra notation for selecting image sizes.

My values line of

![A screenshot of the Wikidata Query Service](<https://upload.wikimedia.org/wikipedia/commons/e/ec/Screenshot_Wikidata_Query_Service_October_2021.png> =1024x)

Is changed to the following when running a fix

![A screenshot of the Wikidata Query Service]\(<https://upload.wikimedia.org/wikipedia/commons/e/ec/Screenshot_Wikidata_Query_Service_October_2021.png> =1024x)

Causing the image to not render When removing the slash and just running lint I see

warning  Found reference to undefined definition  no-undefined-references  remark-lint
vweevers commented 2 years ago

hallmark is based on the remark parser and ecosystem, so a prerequisite is to find or write a remark plugin that can parse this image size syntax. If you can do so in a non-invasive way, I will consider adding it to hallmark.