search

vweevers / win-version-info

Windows-only native addon to read version info from executables.
MIT License
19 stars 6 forks source link

Build for Node 14 #16

Closed pimterry closed 4 years ago

pimterry commented 4 years ago

I'd find a prebuilt Node 14 version of this really useful, so this is a quick PR to enable that.

Unfortunately, testing for myself on appveyor, this seems to work fine for x64, but not x86. Appveyor doesn't seem to show any output, and I don't have an x86 Windows machine to hand to test. Any ideas?

vweevers commented 4 years ago

Node 14 has a known issue on AppVeyor x86; using nodejs_version: 14.2.0 should fix it.

pimterry commented 4 years ago

Great tip, thanks! Looks like it's now building happy :+1:

vweevers commented 4 years ago

3.1.0 (but its build failed so I did not publish this version to npm) and 3.1.1.

PS. We have too many prebuilds now (24 for a single platform, takes almost half an hour to build). I wanna move this to N-API + prebuildify and drop support of node 8 and electron < 4.