search

vwochnik / jekyll-autoprefixer

Autoprefixer integration for Jekyll
MIT License
64 stars 16 forks source link

Only autoprefix in production #2

Closed jacobmischka closed 7 years ago

jacobmischka commented 7 years ago

This was handy for me, because in development I use browser-sync to hot-reload css changes, and autoprefixing made that behave badly. I realize some people might not want this behavior, so I certainly understand if this PR isn't accepted.

vwochnik commented 7 years ago

In this current form, I will not accept this PR, because it has been implemented wrong from my view. You see, when you skip calling site.autoprefixer.process within the post_write hook after you have been adding the files to the batch within the post_render hook, the batch is not cleared after every cycle.

So, I'd rather advice modifying the process method. There, you have an options variable. I will accept a PR where the user has the option to enable or disable this behaviour.

vwochnik commented 7 years ago

Ok, I have released version 1.0.1. Hope this helps.

jacobmischka commented 7 years ago

Ah great, you're right this is better. Thanks for the quick response!

vwochnik commented 7 years ago

Tell me how it goes!

jacobmischka commented 7 years ago

It's perfect, thanks again!