vwout / obs-visca-control

OBS plugin to control Visca-over-IP based cameras
https://obsproject.com/forum/resources/control-visca-over-ip-based-cameras.1173/
GNU General Public License v3.0
35 stars 6 forks source link

Increase/Decrease Pan/Tilt Speed not immediately effective #11

Closed vwout closed 1 year ago

vwout commented 1 year ago

Yesterday, when using the PTZOptics mode, I found that the "Increase Pan/Tilt Speed" adn "Decrease Pan/Tilt Speed"(A) did not take effect immediately on the camera. I need to press the refresh button(C) in the lower left corner to take effect, but the value here has changed(B).

微信图片_20230218090822

微信图片_20230218090732

Originally posted by @PoWeR-Ding in https://github.com/vwout/obs-visca-control/issues/8#issuecomment-1435436974

vwout commented 1 year ago

The speed increase/decrease shortcuts actually do have immediate effect. This is only shown in the settings after reload - this is a limitation of OBS. The speed however was only applied at the first hotkey use. Changing the speed afterwards has no effect until the plugin is reloaded. This bug is resolved in 33c621a.

PoWeR-Ding commented 1 year ago

OK, copy. I will test as soon as possible

PoWeR-Ding commented 1 year ago

微信截图_20230219235750 微信图片_20230219235509

Hello, I can't control the camera after updating the script.

PoWeR-Ding commented 1 year ago

Now, after changing the speed, it will take effect immediately. But the up, down, left and right directions cannot be controlled.

微信截图_20230220001321

PoWeR-Ding commented 1 year ago

"Zoom In" and "Zoom Out" are also normal. √

vwout commented 1 year ago

Sorry about that; my fix was too quick (not properly tested). Should be resolved now.

PoWeR-Ding commented 1 year ago

Never mind, I will continue to test😂😂

PoWeR-Ding commented 1 year ago

微信截图_20230220091752 Script Log.txt

This time, "Zoom In" and "Zoom Out" will not take effect. 😣 😣 😣 😣

vwout commented 1 year ago

Now it should finally work - without breaking stuff. This finally made me start on writing unit tests for the OBS plugin script as well ...

PoWeR-Ding commented 1 year ago

Thanks for the patient repair. I will continue to test it.

PoWeR-Ding commented 1 year ago

Good morning, vwut

I tested it again and there was no problem.

Thanks again.