search

vwout / obs-visca-control

OBS plugin to control Visca-over-IP based cameras
https://obsproject.com/forum/resources/control-visca-over-ip-based-cameras.1173/
GNU General Public License v3.0
35 stars 6 forks source link

Want to capture camera current PTZ values and save them in the scene #4

Closed tmimlitch closed 2 years ago

tmimlitch commented 2 years ago

Here are my versions of your control and libvisca LUA scripts for your review/comment etc. Ive only changed the names so my development work remained separate from your original scripts

obs-visca-controlPTZ_V3.zip .

tmimlitch commented 2 years ago

obs_client_server_simulator.zip

I dont have a cam at home to test with eithe so I wrote some client server scripts to simulate the inquire and control side without really doing anything but sending canned responses. I only needed the PTZ labeled script and ran in on an old PC (still W7) under OBS, would iniialize it via the Start and Receive buttons, Then could run my/your script on my current PC and test and debug it.

CapsAdmin commented 2 years ago

Wouldn't it be easier to review the changes if you made a pull request? If you're not familiar with how, there are plenty of tutorials on youtube.

I don't have a camera to test with either, so the simulator scripts seem useful as well. (I'm mostly interested in this project because of the luajitsocket library I made.)

tmimlitch commented 2 years ago

Thank you for your suggestion.  Ive never worked in this environment before so i didnt know the process.  Ill go back and learn it thanks.   I made no changed to your luajitsocket script, indeed i barely understood it at all.  But it is certainly the foundation for all this script.   Vwout is already looking at correcting my crude patchwork. And at his suggestion that i used this method to be able to upload my mods for him to look at. Thanks again.  ToM.

Sent from Yahoo Mail on Android

On Sun, Jul 10, 2022 at 2:28 AM, Elias @.***> wrote:

Wouldn't it be easier to review the changes if you made a pull request. If you're not familiar with how, there are plenty of tutorials on youtube.

I don't have a camera to test with either, so the simulator scripts seem useful as well. (I'm mostly interested in this project because of the luajitsocket library I made.)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

vwout commented 2 years ago

The suggested changes and new features have been implemented in the main branch, ready for testing. Note: this requires a camera that send responses on same socket that send the command to the camera.

vwout commented 2 years ago

Implementation is confirmed on Everet cameras. Will be available as of next release (or immediately from source).

tmimlitch commented 1 year ago

vwout, I finally got to try out your latest obs-visca-control (09/02/2022 i believe), and it worked great.  I ran it thru its paces on one camera with four scenes and various absolute locations.  I did have to press the retrieve current position button twice to get the values to display, but that is fine.  Loved your user interface and the speed control too.  I looked briefly at your code changes and I am in awe,  it would take me another lifetime to figure all that out.  Thank you for all your fantastic work on this. 

I've attached my scenes json file below of this test run. ToM.