vwout / obs-visca-control

OBS plugin to control Visca-over-IP based cameras
https://obsproject.com/forum/resources/control-visca-over-ip-based-cameras.1173/
GNU General Public License v3.0
35 stars 6 forks source link

Unable to load script #5

Closed PoWeR-Ding closed 1 year ago

PoWeR-Ding commented 1 year ago

@vwout

As shown in the following figure: 微信截图_20221009160930

微信截图_20221009161017

CapsAdmin commented 1 year ago

can you post the full log?

PoWeR-Ding commented 1 year ago

@CapsAdmin

Crash 2022-10-09 16-44-44.txt

PoWeR-Ding commented 1 year ago

@CapsAdmin
Crash 2022-10-09 16-08-52.txt

CapsAdmin commented 1 year ago

hmm, assuming it's this causing the crash https://github.com/vwout/obs-visca-control/blob/main/obs-visca-control.lua#L720

it could be related to your unusual obs location. What happens if you put it obs directly under c:\users\72709\desktop\obs\* without any chinese characters?

PoWeR-Ding commented 1 year ago

@CapsAdmin

The 1.6 version runs normally. ↓↓↓↓↓↓↓↓ 微信截图_20221009224108

2.0 version ↓↓↓↓↓↓↓↓ 微信截图_20221009224131

微信截图_20221009224152

Crash 2022-10-09 22-41-45.txt

vwout commented 1 year ago

@CapsAdmin is probably right

hmm, assuming it's this causing the crash https://github.com/vwout/obs-visca-control/blob/main/obs-visca-control.lua#L720

Can you remove line 720 from obs-visca-control.lua?

When that does not crash, add the following line at the location at line 720: obs.obs_properties_add_path(backup_props, "backup_file", "Backup file", obs.OBS_PATH_FILE_SAVE, "*.json", nil)

PoWeR-Ding commented 1 year ago

@vwout

remove line 720 from obs-visca-control.lua,and then the script loading is normal. √√√√√ ↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓

微信截图_20221010100221 微信截图_20221010101248

add the following line at the location at line 720: obs.obs_properties_add_path(backup_props, "backup_file", "Backup file", obs.OBS_PATH_FILE_SAVE, "*.json", nil) ↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓

微信截图_20221010101415

Crash 2022-10-10 10-14-07.txt

vwout commented 1 year ago

Thanks for the confirmation. The code seems to contain a bug, where two arguments are reversed (the search path 'nil' and the file filter '*.json'). The crash however persists, so that seems to be a bug in OBS.

When you leave out the lines 719-723, the plugin will fully work. Only the ability to backup and restore settings is removed. I will try to check the issue with OBS.

PoWeR-Ding commented 1 year ago

@vwout Thank you very much for your handling.

vwout commented 1 year ago

There is one more thing you could check in case you are in the position to install and test OBS 28. OBS 28 does contain some breaking changes (and NDI does not work yet), so you might not want to do that. But in case you do, it would be interesting to see if the issue is resolved. OBS 28 contains an updated graphics library (QT6).

I can't test this for you unfortunately. The issue seems to be related to the use of Chinese (unicode or multibyte character sets) since I can't reproduce it on an English Windows distribution.

vwout commented 1 year ago

@PoWeR-Ding were you by any chance able to test with OBS 28?

PoWeR-Ding commented 1 year ago

@vwout Sorry, I ignored it a while ago.

This problem has been solved on OBS 28.

微信截图_20221021135722 微信截图_20221021135758 微信截图_20221021135819

PoWeR-Ding commented 1 year ago

@vwout It should be that the OBS built by myself cannot be used.

I use the normal one on the official website OBS 27.

微信截图_20221021142956

vwout commented 1 year ago

To be sure I understand: it does work with the official release of both OBS 27 and 28? The issue only occurs on your own build?

PoWeR-Ding commented 1 year ago

yep. sorry.

The current test is indeed like this.

vwout commented 1 year ago

Thanks for confirming. Then the fix in f0fed4975021c2a392c08fe1f568c0d8c52a8e5c concludes this ticket.