Closed PoWeR-Ding closed 1 year ago
can you post the full log?
@CapsAdmin
@CapsAdmin
Crash 2022-10-09 16-08-52.txt
hmm, assuming it's this causing the crash https://github.com/vwout/obs-visca-control/blob/main/obs-visca-control.lua#L720
it could be related to your unusual obs location. What happens if you put it obs directly under c:\users\72709\desktop\obs\*
without any chinese characters?
@CapsAdmin
The 1.6 version runs normally.
↓↓↓↓↓↓↓↓
2.0 version
↓↓↓↓↓↓↓↓
@CapsAdmin is probably right
hmm, assuming it's this causing the crash https://github.com/vwout/obs-visca-control/blob/main/obs-visca-control.lua#L720
Can you remove line 720 from obs-visca-control.lua?
When that does not crash, add the following line at the location at line 720:
obs.obs_properties_add_path(backup_props, "backup_file", "Backup file", obs.OBS_PATH_FILE_SAVE, "*.json", nil)
@vwout
remove line 720 from obs-visca-control.lua,and then the script loading is normal. √√√√√ ↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓
add the following line at the location at line 720: obs.obs_properties_add_path(backup_props, "backup_file", "Backup file", obs.OBS_PATH_FILE_SAVE, "*.json", nil) ↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓
Thanks for the confirmation. The code seems to contain a bug, where two arguments are reversed (the search path 'nil' and the file filter '*.json'). The crash however persists, so that seems to be a bug in OBS.
When you leave out the lines 719-723, the plugin will fully work. Only the ability to backup and restore settings is removed. I will try to check the issue with OBS.
@vwout Thank you very much for your handling.
There is one more thing you could check in case you are in the position to install and test OBS 28. OBS 28 does contain some breaking changes (and NDI does not work yet), so you might not want to do that. But in case you do, it would be interesting to see if the issue is resolved. OBS 28 contains an updated graphics library (QT6).
I can't test this for you unfortunately. The issue seems to be related to the use of Chinese (unicode or multibyte character sets) since I can't reproduce it on an English Windows distribution.
@PoWeR-Ding were you by any chance able to test with OBS 28?
@vwout Sorry, I ignored it a while ago.
This problem has been solved on OBS 28.
@vwout It should be that the OBS built by myself cannot be used.
I use the normal one on the official website OBS 27.
To be sure I understand: it does work with the official release of both OBS 27 and 28? The issue only occurs on your own build?
yep. sorry.
The current test is indeed like this.
Thanks for confirming. Then the fix in f0fed4975021c2a392c08fe1f568c0d8c52a8e5c concludes this ticket.
@vwout
As shown in the following figure:![微信截图_20221009160930](https://user-images.githubusercontent.com/112599924/194745466-50ccf743-b529-4cb5-92c7-a9c77685b3f6.png)