Closed vwxyzjn closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/AuRtE9dc44G88RDWW5CapYTxT3Pe
✅ Preview: https://cleanrl-git-dqnpy-docs-addition-vwxyzjn.vercel.app
This PR is ready for review.
Additional note: I realized it would be pretty hard to run benchmark experiments based on some master's version. From now on, we should do something like
gh pr checkout 157
poetry install
in the reproducibility instructions.
Looking good over here too. I noticed there is no dqn_atari.py benchmarks in the docs though. Will it be alright ?
The dqn_atari.py
docs are already added from #124.
Let me know if this addresses your concern :)
Description
This PR adds documentation for
dqn.py
and couple documentation fixes fordqn_atari.py
Types of changes
Checklist:
pre-commit run --all-files
passes (required).mkdocs serve
.If you are adding new algorithms or your change could result in performance difference, you may need to (re-)run tracked experiments. See https://github.com/vwxyzjn/cleanrl/pull/137 as an example PR.
--capture-video
flag toggled on (required).mkdocs serve
.width=500
andheight=300
).