vwxyzjn / cleanrl

High-quality single file implementation of Deep Reinforcement Learning algorithms with research-friendly features (PPO, DQN, C51, DDPG, TD3, SAC, PPG)
http://docs.cleanrl.dev
Other
5.54k stars 631 forks source link

Poetry 1.2 #271

Closed vwxyzjn closed 2 years ago

vwxyzjn commented 2 years ago

Description

Adopting poetry 1.2 support. The locking and adding dependencies are orders of magnitude faster!

Types of changes

Checklist:

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cleanrl ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 4:39PM (UTC)
vwxyzjn commented 2 years ago

@Dipamc77 and @dosssman this PR is ready for review.

dosssman commented 2 years ago

@vwxyzjn Hello there. Attempted to test the workflow from scratch by installing poetry 1.2.1 as per their docs using this command: curl -sSL https://install.python-poetry.org | python3 -, but running poetry install in cleanrl directory while under the poetry1.2 branch just hangs. Is it on my side only ?

$ poetry install
Creating virtualenv cleanrl-iXm2iEAu-py3.9 in /home/d055/.cache/pypoetry/virtualenvs
Installing dependencies from lock file

Package operations: 67 installs, 1 update, 0 removals

  • Installing certifi (2022.6.15.1): Pending...
  • Installing charset-normalizer (2.1.1): Pending...
  • Installing idna (3.3): Pending...
  • Installing pyasn1 (0.4.8): Pending...
  • Installing pyparsing (3.0.9): Pending...
  • Installing urllib3 (1.26.12): Pending...

Or is my luck just that bad today ? :sweat_smile:

vwxyzjn commented 2 years ago

@dosssman could you try export PYTHON_KEYRING_BACKEND=keyring.backends.null.Keyring? I think it's related to https://github.com/python-poetry/poetry/issues/1917

dosssman commented 2 years ago

Thanks a lot. This seems to have done the trick now.