Closed dosssman closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
cleanrl | ✅ Ready (Inspect) | Visit Preview | Oct 19, 2022 at 6:46PM (UTC) |
@vwxyzjn td3 continuous JAX variant will probably be affected too though.
@joaogui1 could you check if TD3 (JAX) will be affected?
@vwxyzjn check whether the jax implementation affected by this PR or if it will also need a fix like this PR?
@joaogui1, the latter :)
Got it, it will need to be fix, creating the PR this moment
@dosssman thank you for the PR! Would you mind running some benchmark experiments to see if this change has a significant impact on the performance? If not, we don't even have to update the docs, since the main purpose of re-doing benchmark is to ensure no regression in performance.
There is a performance regression on the Walker2d env, but the others are only marginally affected:
Report here
Hmm interesting. Thanks for running the expriments. Although one experiment failed... Would you mind re-running it?
Given that this is a performance-impacting change, I am re-running the benchmark now.
No material change to the performance (there is a minor regression in Walker2d-v2
. I am going to update the docs and merge the PR. The regression report is at https://wandb.ai/openrlbenchmark/cleanrl-cache/reports/-281-CleanRL-s-TD3-TD3-Trgt-Action-Noise-Sample-Check--VmlldzoyODE5MTg0
Description
Closes #279.
Types of changes
Checklist:
pre-commit run --all-files
passes (required).[ ] I have updated the documentation and previewed the changes viamkdocs serve
.If you are adding new algorithms or your change could result in performance difference, you may need to (re-)run tracked experiments. See https://github.com/vwxyzjn/cleanrl/pull/137 as an example PR.
--capture-video
flag toggled on (required).mkdocs serve
.width=500
andheight=300
).