As discussed on Discord, I've done basic type hints for PPO and DQN. Everything checks out with mypy 0.982 (mypy cleanrl/ppo.py --show-error-codes --ignore-missing-imports). Of course we can have a discussion about whether that's the checker that will be used if we go further down the road of implementing this. I'll put comments in noteworthy places.
The tests fail because tuple[int] or list[int] only works from Python 3.9 on.
Description
As discussed on Discord, I've done basic type hints for PPO and DQN. Everything checks out with mypy 0.982 (
mypy cleanrl/ppo.py --show-error-codes --ignore-missing-imports
). Of course we can have a discussion about whether that's the checker that will be used if we go further down the road of implementing this. I'll put comments in noteworthy places.The tests fail because
tuple[int]
orlist[int]
only works from Python 3.9 on.Types of changes
Checklist:
pre-commit run --all-files
passes (required).