Closed dtch1997 closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
cleanrl | ✅ Ready (Inspect) | Visit Preview | Nov 15, 2022 at 2:12AM (UTC) |
Experiments ongoing: https://wandb.ai/dtch1997/cleanRL?workspace=user-dtch1997
@dtch1997 thanks for this PR. Great work! Your work also made me realize we could probably support gym and gymnasium simultaneously since they have different package names. We could probably save all of the gymnasium scripts under the gymnasium folder and then gradually migrate to gymnasium. #277 #263
Let me fix the CI
@dtch1997 could you give me write access to the branch?
@vwxyzjn the option doesn't show up for me, after following Github docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
I added you as a collaborator on the downstream fork instead, does that help?
Thanks for giving it a try but it wasn't quite working...
I think the "allow edits from maintainer" option wasn't there because the PR is based on your master branch. Would you mind creating another branch and filing another PR?
Closed as a duplicate of #319
Description
This PR modifies
ppo_continuous_action.py
to work with Gymnasium environments.Types of changes
Checklist:
pre-commit run --all-files
passes (required).mkdocs serve
.If you are adding new algorithm variants or your change could result in performance difference, you may need to (re-)run tracked experiments. See https://github.com/vwxyzjn/cleanrl/pull/137 as an example PR.
--capture-video
flag toggled on (required).mkdocs serve
.