Closed dosssman closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
cleanrl | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 8, 2023 3:35am |
Didn't manage to get the rlops working yet, so regression report was done manually:
So the version that has the bug fixed is actually worse? That's odd.
Happened a few times before. Probably due to stochasticity that occurs during the sampling process, or due to the difference en environment / hardware. Might add more runs to ascertain it, if you feel like it is necessary. Performance regression is only on Walker2d it seems, the rest has very close performance to the rl-pilot baseline.
Might add more runs to ascertain it, if you feel like it is necessary.
I can run a couple of experiments if you like but not before May 18th. But to me, it looks OK.
Probably due to stochasticity
I agree. We'd probably need 50+ runs to properly verify anything anyway, that's a little excessive :D
All good on my side too.
Fixes #379
Description
Address issues pointed out in #379
Types of changes
Checklist:
pre-commit run --all-files
passes (required).I have updated the tests accordingly (if applicable).mkdocs serve
.If you need to run benchmark experiments for a performance-impacting changes:
--capture-video
.python -m openrlbenchmark.rlops
.python -m openrlbenchmark.rlops
utility to the documentation.python -m openrlbenchmark.rlops ....your_args... --report
, to the documentation.