vwxyzjn / cleanrl

High-quality single file implementation of Deep Reinforcement Learning algorithms with research-friendly features (PPO, DQN, C51, DDPG, TD3, SAC, PPG)
http://docs.cleanrl.dev
Other
5.41k stars 616 forks source link

bump poetry to 1.3.1 #394

Closed sdpkjc closed 1 year ago

sdpkjc commented 1 year ago

Description

Poetry 1.3 has led to a bug our CI fails, see https://github.com/python-poetry/poetry/issues/7171

https://github.com/python-poetry/poetry/pull/7169 fixed the issue, ~I suggest to bump poetry directly to 1.4 and get our CI healthy again.~

Types of changes

Checklist:

If you need to run benchmark experiments for a performance-impacting changes:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cleanrl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 3:07pm
sdpkjc commented 1 year ago

The Modern installer in poetry 1.4 causes our CI to fail under Windows. https://github.com/python-poetry/poetry/issues/7611

1.3.1 does not have this problem and fixes the bug mentioned earlier.

Now our CI is working and we're ready to merge.