Open XinJingHao opened 6 months ago
Hi! The repo C51 really helps a lot!
However, I have a question. In line 226 and 227: l = b.floor().clamp(0, args.n_atoms - 1) u = b.ceil().clamp(0, args.n_atoms - 1)
l = b.floor().clamp(0, args.n_atoms - 1)
u = b.ceil().clamp(0, args.n_atoms - 1)
It seems that the clamp() function is redundant? Because t_z is already in v_min and v_max. Why do we still use it here?
clamp()
t_z
v_min
v_max
Looking forward to your reply~ Thanks
Hi! The repo C51 really helps a lot!
However, I have a question. In line 226 and 227:
l = b.floor().clamp(0, args.n_atoms - 1)u = b.ceil().clamp(0, args.n_atoms - 1)It seems that the
clamp()function is redundant? Becauset_zis already inv_minandv_max. Why do we still use it here?Looking forward to your reply~ Thanks