search

vwxyzjn / portwarden

Create Encrypted Backups of Your Bitwarden Vault with Attachments
MIT License
577 stars 33 forks source link

Support for passphrases with spaces #30

Closed x49QK2S25Jv closed 4 years ago

x49QK2S25Jv commented 4 years ago

Any chance it could support passphrases with spaces?

vwxyzjn commented 4 years ago

Hi, is there a compelling reason for the support? Get Outlook for iOShttps://aka.ms/o0ukef

From: Kevin notifications@github.com Sent: Friday, June 26, 2020 2:51:44 PM To: vwxyzjn/portwarden portwarden@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [vwxyzjn/portwarden] Support for passphrases with spaces (#30)

Any chance it could support passphrases with spaces?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/vwxyzjn/portwarden/issues/30, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABKMJEZE4PXY5HBICWTHAITRYTU4BANCNFSM4OJSQONQ.

x49QK2S25Jv commented 4 years ago

I've got one or more spaces in my passphrase

vwxyzjn commented 4 years ago

For now, I would suggest using a pass phrase without spaces. Introducing spaces to pass phrases might make the implementation a little tricky (could introduce bugs), so I am a little reserved for adding this new feature.

Of course, PR is always welcome.