vy / log4j2-redis-appender

A Log4j 2 Appender for Redis.
Apache License 2.0
33 stars 10 forks source link

Redis username #132

Closed rmarticaba closed 6 months ago

rmarticaba commented 6 months ago

Hi!

Thanks for bringing this tool.

I was trying to use it to store my application logs into redis, but I bumped into an issue when trying to use a username different from default, as it is not configurable. I did small changes to allow to use a different username and configure it through log4j2.xml and I'd like to contribute those changes if you see them ok, but I lack permissions to push a new branch with the proposed changes.

Please share if that is something I can contribute with.

vy commented 6 months ago

@rmarticaba, sounds like a good idea. Please submit a PR. I would appreciate it if you can

rmarticaba commented 6 months ago

Thanks @vy,

I submitted the PR with the changes and testing (I adapted existing tests to use the new username / password pair)

vy commented 6 months ago

Fixed by #134.