vyadh / teamcity-deployment-dashboard

A TeamCity dashboard to help summarise what app version has been released to what environment.
Apache License 2.0
25 stars 6 forks source link

Strange behaviour #2

Closed bankinobi closed 5 years ago

bankinobi commented 5 years ago

Hello Vyadh! Trying to set up your awesome plugin, but i'm stuck. I have a project with below settings: Selection_011 I want to see a branch name on dashboard. So after deploying master branch i tried to deploy tagged branch 1.0.2 Selection_007 Branch name appears on dashboard while it was deploying Selection_009 But after deploy branch name on dashboard changed to "master" again Selection_010 What i'm doing wrong?

vyadh commented 5 years ago

Hi Bankinobi. Thanks for the feedback and the great bug report. I think understand why this is happening. The plugin first fetches the last running build and displays that, but if there isn't a running build, it queries the "last changes finished" build, which I thought just got the last run build, but given your query and having another look, I found a note that said it actually takes the build from default branch. So I'm guessing your master is your default branch right?

So given what we need to do on the dashboard, the function I'm using clearly isn't quite right. I've found an alternative. It's slightly more involved (need to process the build history), but I'll get that sorted over the weekend.

Thanks for pointing this out!

vyadh commented 5 years ago

Okay, I've fixed the problem as above by using an alternative / lower-level way of querying the build history. The dashboard should now always reflect the most recent version deployed no matter what branch was used. Thanks for pointing this out.

You should be able to see this update available from TeamCity. The release notes are here which also has a few other minor changes.

Let me know if you have further problems, either by reopening this issue or by opening a new one.

bankinobi commented 5 years ago

Works like a charm. Thank you! Selection_013