Further improvements / maintenance

vydd / sketch

A Common Lisp framework for the creation of electronic art, visual design, game prototyping, game making, computer graphics, exploration of human-computer interaction, and more.

MIT License

1.39k stars 67 forks source link

Further improvements / maintenance #80

Closed Gleefre closed 9 months ago

Gleefre commented 9 months ago

Hello,

Due to the library becoming stale, as @Kevinpgalligan suggested in #74, I'll keep working on it at my fork only: https://github.com/Gleefre/sketch. Feel free to open pull requests and raise new issues there :).

@vydd if you choose to resume your work on sketch, I would be glad to open several pull-requests to backport our changes.

vydd commented 9 months ago

Hey @Gleefre ! Sorry for not doing a good job at reviewing, super busy times.

You are of course free to maintain a fork, but I feel it'd be better for everyone if we found a way to get your changes into here.

If you would describe where you want to go with the fork/changes, it'd be much easier for me to review at a more regular cadence. As it stands, whenever I do it, it's a huge context switch for me, as figuring out why someone is proposing a certain change at a certain time can be difficult.

Gleefre commented 9 months ago

Hi!

Not sure what you mean by where I want to go; but my goal is to create a faster moving branch, that would be easier to contribute to (for me as well as for others).

Aside from small bug fixes I also plan to work on features like

easier building for applications. define-start-function is currently working, but I'm still thinking about its API.
fix the default width/height solution I've been using - which would probably include rewriting defsketch macro and removing the prepare method.
separate the public API from the SDL2/OpenGL backend. Maybe add other backends.
exposing some internals of the backend, for example to get a configurable mag filter in openGL to resize images without them getting blurred.
figure out for myself and maybe document sketch components like shaders, figures, controllers and channels.

Gleefre commented 9 months ago

I feel it'd be better for everyone if we found a way to get your changes into here.

Sure, I'd like that too, but at the same time it does feel demotivating when PRs get stuck for a huge amount of time without any feedback. I also find it not great to open PRs while (a lot of) previous ones are still open, as it can result in merge conflicts when someone wants to merge them.

I'd be happy to reopen PRs that were closed due to me renaming branches if you want to review them any time soon.

vydd commented 9 months ago

I can go through PRs later today if you reopen them. Let's try to make this work.

Gleefre commented 9 months ago

Alright :).

Gleefre commented 9 months ago

I'll be closing this issue now.

Do you plan to actively work on sketch, or you are just reviewing PR for now?

vydd commented 9 months ago

Let's say it's reviewing PRs for now and discussion. I am actively thinking about channels again, though.

Here's something else you can do with channels (as a continuation from our irc discussion... maybe we should create an issue for it):

(defsketch add 
    ((c (in :c 0)))
  (text (format nil "~a" c) 100 100))

(define-channel-observer
  (out :c (+ (in :a 0) (in :b 0))))

with that defined, you can see the number changing as you send numbers to :a and :b in repl (using (out :a 5))