search

vyleung / logseq-helium-plugin

a Logseq plugin to float items (e.g. videos) for an improved note-taking experience
MIT License
84 stars 6 forks source link

v 1.1.1 and v 1.0.1difference #3

Closed lion-no-back closed 2 years ago

lion-no-back commented 2 years ago

Hello, the effect of the plugin is very nice, but there is a small problem. In the latest version of v.1.1.1, the video on my side can't be floated. I can use v1.0.1.Besides,my computer is win11. I really like this one you developed. plugin

vyleung commented 2 years ago

hi! is the video you're floating a youtube video or another type of video? also, is the balloon icon being shown when you attempt to float the video?

lion-no-back commented 2 years ago

Other types of videos，then show the balloon icon but it doesn't work

vyleung commented 2 years ago

gotcha - would you mind sending me a link to a video that isn't able to be floated?

lion-no-back commented 2 years ago

The videos I downloaded from Bilibili are offline what else can I offer

lion-no-back commented 2 years ago

https://user-images.githubusercontent.com/100990301/167238811-becf0e24-dae9-44cb-8885-f198e2c8b207.mp4

vyleung commented 2 years ago

the video was super helpful - thanks! this issue should hopefully be fixed in v.1.1.2

lion-no-back commented 2 years ago

Hmm, looking forward to it

vyleung commented 2 years ago

the marketplace should now have v.1.1.2 - please update the plugin and let me know if the issue is fixed

lion-no-back commented 2 years ago

You are very efficient. I just tried it, but it still doesn't work.

lion-no-back commented 2 years ago

Sorry, there was a problem with the test, and now it can be used normally.

lion-no-back commented 2 years ago

great！！！

lion-no-back commented 2 years ago

awesome

vyleung commented 2 years ago

happy to hear that it's been fixed 🙂