search

vyleung / logseq-helium-plugin

a Logseq plugin to float items (e.g. videos) for an improved note-taking experience
MIT License
84 stars 6 forks source link

Feature request: Enlarge or narrow with Proportion. #4

Closed mzwlevi closed 2 years ago

mzwlevi commented 2 years ago

The helium-plugin is wonderful, which solve the problem with write video notes in logseq 🎉. Any plan to add the function: Enlarge or narrow with Proportion? This will improve efficiency, currently I need to increase the height then increase the width 🥲.

vyleung commented 2 years ago

thanks for the feature request! a new option has been added in v.1.1.3 to simultaneously increase/decrease the height and width of youtube videos - let me know if this works for you

logseq_helium_issue4_update

mzwlevi commented 2 years ago

thanks for the feature request! a new option has been added in v.1.1.3 to simultaneously increase/decrease the height and width of youtube videos - let me know if this works for you

logseq_helium_issue4_update

nice!

mzwlevi commented 2 years ago

thanks for the feature request! a new option has been added in v.1.1.3 to simultaneously increase/decrease the height and width of youtube videos - let me know if this works for you

logseq_helium_issue4_update

I have updated the latest helium version, but it does not work for me, I'm using the v0.6.8 of Logseq.

Screen Shot 2022-05-15 at 09 41 05

https://user-images.githubusercontent.com/78029539/168453723-a6101eae-5920-46ad-b736-f5d4c78a1102.mov

mzwlevi commented 2 years ago

I have cleared the cache, reindex, reopen LS, reinstall helium, back to the default theme, but nothing happened.

vyleung commented 2 years ago

that's super weird - i tried to reproduce this error but couldn't

https://user-images.githubusercontent.com/64292157/168454274-bb8de065-08b1-4e5d-b91b-0774f1c364f1.mp4

can you disable and re-enable the plugin? then open dev tools (mac: cmd+option+i | windows: ctrl+shift+i) - you should see "logseq-helium-plugin loaded". let me know if there are any errors that pop up

mzwlevi commented 2 years ago

When I click the start float, the console shows:

Screen Shot 2022-05-15 at 10 15 44
vyleung commented 2 years ago

can you go into edit mode for the block w/ the video and send a screenshot? it may be an issue w/ the format of the url

mzwlevi commented 2 years ago

Screen Shot 2022-05-15 at 10 22 26

mzwlevi commented 2 years ago

Screen Shot 2022-05-15 at 10 24 32 I found this in the console

vyleung commented 2 years ago

gotcha - the plugin doesn't currently support the shortened url format. i'll work on adding this to the next release

can you try using the video's full url? - {{youtube https://www.youtube.com/watch?v=JbBUlojyvhs}}

mzwlevi commented 2 years ago

gotcha - the plugin doesn't currently support the shortened url format. i'll work on adding this to the next release

can you try using the video's full url? - {{youtube https://www.youtube.com/watch?v=JbBUlojyvhs}}

Nice, It works, thank you!  👍

vyleung commented 2 years ago

happy to hear that!

vyleung commented 2 years ago

shortened YouTube URLs should now be supported in v.1.1.4

mzwlevi commented 2 years ago

shortened YouTube URLs should now be supported in v.1.1.4

👏