search

vyleung / logseq-helium-plugin

a Logseq plugin to float items (e.g. videos) for an improved note-taking experience
MIT License
85 stars 6 forks source link

Increasing the width shows a scroll bar #5

Open nashamri opened 2 years ago

nashamri commented 2 years ago

First of all, thank you @vyleung for this plugin, it's really useful!

I noticed a little issue today as shown in the following video:

https://user-images.githubusercontent.com/1207107/169596820-5982c869-5d10-4344-949e-1182f2f7139d.mp4

As you can see, whenever I try to increase the width, the video div seems to have a css property of overflow: scroll; or something like that. And the H button doesn't work and doesnt affect the height of the video.

I'm using logseq version 0.6.8 on my linux machine.

vyleung commented 2 years ago

hi Nasser, glad you find the plugin useful!

part 1:

whenever I try to increase the width, the video div seems to have a css property of overflow: scroll; or something like that.

  • this is currently a limitation since i use position: sticky to get the block to stick to the top of the page and can't use position: absolute to show the overflow - i'll try my best to find a solution to this, but no promises

part 2:

And the H button doesn't work and doesnt affect the height of the video.

  • i'm not able to reproduce this error - some troubleshooting questions:
    1. are you on the latest version of the plugin (v.1.1.4)?
    2. can you try disabling/re-enabling the plugin and refresh Logseq?
    3. are there any errors in dev tools (you can open it using ctrl+shift+i)?
nashamri commented 2 years ago

For part 2:

  1. Yes I'm using v.1.1.4
  2. Tried that and restarted Logseq and the issue still there.
  3. From what I see, I don't think there are any errors that show up in the console. I've make a little video demoing that:

https://user-images.githubusercontent.com/1207107/169644047-f47e00df-f47e-4214-a537-21bcb4a9a272.mp4

vyleung commented 2 years ago

that's odd - could you uninstall the plugin, download the release from github, and load it manually?

also, i don't think the issue has to do w/ the video itself, but could you send me the video link so that i can test it on my end?

nashamri commented 2 years ago

I tried another video and I get the same result. Here's the link to the video anyways: https://www.youtube.com/watch?v=OyfBQmvr2Hc

nashamri commented 2 years ago

I tried to load it manually from github, and I get the same behaviour.

vyleung commented 2 years ago

can you follow the video attached to use dev tools to inspect the +/- buttons for the height? at the end of the video, i showed that i can't reproduce the error you're facing

https://user-images.githubusercontent.com/64292157/169662067-7fd3a97b-7403-482f-99c0-3fb78f3f2aaa.mp4

nashamri commented 2 years ago

Thanks for that, I see that you are using a mac and I'm using linux, it could be an issue with my distro, I'm using logseq on NixOS and it might be an issue with my setup, I'll try to test it with another machine and get back to you.

vyleung commented 2 years ago

figured out a solution to part 1! check out v.2.0.0 🙂

nashamri commented 2 years ago

Hello @vyleung good job :+1: , yes I confirm that par1 issue is resolved with v2.0.1