vyleung / logseq-helium-plugin

a Logseq plugin to float items (e.g. videos) for an improved note-taking experience
MIT License
85 stars 6 forks source link

Problems when floating the video #6

Closed mendax1234 closed 2 years ago

mendax1234 commented 2 years ago

My logseq version is 0.6.9 , it seems that after select the whole part of code of the video. l choose the start floating , but nothing happens. Can you give some more specific steps on how to float the video. Thanks!

My operating system is windows10 pro.

vyleung commented 2 years ago

hi Daniel! floating the video should be as simple as what you’ve described. what type of video are you trying to float (e.g. YouTube, Vimeo, local video)?

if you’re able to, could you screen record a quick video of the issue?

mendax1234 commented 2 years ago

It seems that l don't know how to start floating. l find that after l click the red ballon , what should l do? When should l select my code?

vyleung commented 2 years ago

hopefully this video helps to clarify

mendax1234 commented 2 years ago

Thanks , that'r great , l can float the video now!

mendax1234 commented 2 years ago

@vyleung Do you know how to change the size of window of the video?

vyleung commented 2 years ago

check out this video starting at the 10 sec mark

mendax1234 commented 2 years ago

Thanks , but it seems that l only have this red ballon . l don't have the button to change the size. image

vyleung commented 2 years ago

i forgot to mention - currently, only YouTube videos can be resized

mendax1234 commented 2 years ago

Oh, thanks.

mendax1234 commented 2 years ago

Can you add the local video support? Thanks!

mendax1234 commented 2 years ago

Besides , with the youtube video, l still can't change the size. image The button can't be clicked!

vyleung commented 2 years ago

yes, local video support is planned.

can you open dev tools (ctrl+shift+i) and see if there are any errors?

mendax1234 commented 2 years ago

Sure, which part do you want to see?

vyleung commented 2 years ago

can you please do the following:

  1. disable and re-enable the plugin
  2. float the video and click the buttons
  3. take a screenshot of the errors in the console and post it here
mendax1234 commented 2 years ago

image

mendax1234 commented 2 years ago

Every time l click the button to increase the height, it times of this error will be added.

vyleung commented 2 years ago

gotcha - could you send the video link so i can test it on my end?

mendax1234 commented 2 years ago

Sure. https://www.youtube.com/watch?v=9s7zUlTgnDc&t=29s

vyleung commented 2 years ago

thanks, i’ll take a look in a bit

vyleung commented 2 years ago

it looks like the issue is that the video URL contains &t=29s - can you try https://www.youtube.com/watch?v=9s7zUlTgnDc instead?

mendax1234 commented 2 years ago

Thanks , l will try it soon!

mendax1234 commented 2 years ago

The problem is fixed! Thanks! So, when will this function be added to the local video? Besides , can you also add this function to bilibili? Thank you very much!

vyleung commented 2 years ago

glad to hear that!

can you open a new issue for local video support? and as far as i know, Logseq doesn't support bilibili embeds - other users have downloaded bilibili videos and embeded them as local videos so this will go hand-in-hand w/ the new issue

mendax1234 commented 2 years ago

sure, thanks!