search

vyleung / logseq-helium-plugin

a Logseq plugin to float items (e.g. videos) for an improved note-taking experience
MIT License
85 stars 6 forks source link

Change the size of Youtube video #8

Closed mendax1234 closed 2 years ago

mendax1234 commented 2 years ago

l use Logseq 0.7.0 now and l find that l can't change the size of Youtube video. Here is the youtube video link:https://www.youtube.com/watch?v=6Af6b_wyiwI Here is my code to use it in the Logseq{{video https://www.youtube.com/watch?v=6Af6b_wyiwI}} l hope the plugin can be updated to suit the latest version of Logseq. Thanks!

Daniel

vyleung commented 2 years ago

hi Daniel, iā€™m actively working on supporting the new {{video }} macro šŸ™‚

vyleung commented 2 years ago

added in v.2.0.0! let me know if you run into any issues

mendax1234 commented 2 years ago

Thanks! It works for youtube video now, but it doesn't work for the local video, even the start float function is not compatiable with the local video. Can you fix this? Thanks!

vyleung commented 2 years ago

can you share your local video syntax? the one i currently have supported is ![](local video path)

mendax1234 commented 2 years ago

[:video {:controls true :src "path"}]

vyleung commented 2 years ago

gotcha, i haven't seen this syntax before - i'll work on supporting it

mendax1234 commented 2 years ago

Thanks, how can l use your syntax, since mine is from the logseq directly? If l wan to use your syntax by using "/..."how can l do that ? Can you have a look at it ,thanks!

mendax1234 commented 2 years ago

l have tried your syntax and the video still can't be shown.

vyleung commented 2 years ago

can you update to v.2.0.1 and try again using your original syntax?

mendax1234 commented 2 years ago

Sure!

mendax1234 commented 2 years ago

It seems that you haven't updated the 2.0.1 release. It is still 2.0.0 in both you Github release and in the marketplace. @vyleung

vyleung commented 2 years ago

oops - i pushed the commit, but forgot to create a release šŸ˜… please check again

mendax1234 commented 2 years ago

Thanks , it works now , but it seems that there is a bug with this button. image After the first click on the local video, it seems that the status of the video is wrong . For example , like below image Hope this can be fixed!

vyleung commented 2 years ago

hopefully v.2.0.2 fixes this issue

mendax1234 commented 2 years ago

ok :joy: l am trying it now.

mendax1234 commented 2 years ago

Thanks , this bug is fixed now , but l think l have found a new one. If l play the video first and then start floating, it seems that the state of the button is not consistent again. image Hope this can be fixed!

vyleung commented 2 years ago

try v.2.0.3 - thanks for finding all these bugs btw!

mendax1234 commented 2 years ago

It works perfectly now! Thanks for fixing all the bugs šŸ˜„. BTW, hope the translation function can be added soon!