vyos / vyos.vyos

Ansible Network Collection for VyOS
GNU General Public License v3.0
69 stars 62 forks source link

vyos_bgp_address_family doesn't implement config when omitting optional args #285

Open lingfish opened 1 year ago

lingfish commented 1 year ago
SUMMARY

When doing this:

  as_number: 64512
  address_family:
    - afi: "ipv4"
      redistribute:
        - protocol: "static"

There is no change. I have to add metric: 1 for it to take effect.

When doing this:

  as_number: 64512
  address_family:
    - afi: "ipv4"
      networks:
      - prefix: 152.110.3.0/24

There is no change. To trigger a change I have to specify something like backdoor: true, when the base config is perfectly valid.

It's like args aren't known to be optional.

The same thing happens with gathered, if stock config is there, it isn't recognised at all.

ISSUE TYPE
COMPONENT NAME

vyos_bgp_address_family

ANSIBLE VERSION
  config file = /home/user/ansible-env/ansible.cfg
  configured module search path = ['/home/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/user/.virtualenvs/ansible-new/lib/python3.9/site-packages/ansible
  ansible collection location = /home/user/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/user/.virtualenvs/ansible-new/bin/ansible
  python version = 3.9.6 (default, May 27 2022, 16:26:22) [GCC 6.3.0 20170516]
  jinja version = 3.0.3
  libyaml = True
COLLECTION VERSION
# /home/user/.virtualenvs/ansible-new/lib/python3.9/site-packages/ansible_collections
Collection Version
---------- -------
vyos.vyos  2.6.0

# /home/user/.ansible/collections/ansible_collections
Collection Version
---------- -------
vyos.vyos  4.0.0
CONFIGURATION
DEFAULT_GATHERING(/home/user/ansible-env/ansible.cfg) = smart
DEFAULT_HOST_LIST(/home/user/ansible-env/ansible.cfg) = ['/home/user/ansible-env/inventory']
DEFAULT_STDOUT_CALLBACK(/home/user/ansible-env/ansible.cfg) = yaml
OS / ENVIRONMENT

Controller: Debian stretch VyOS: 1.3

STEPS TO REPRODUCE

As above.

EXPECTED RESULTS

I expect changes to occur with standard defaults.

ACTUAL RESULTS

As above, no changes.

melankh commented 11 months ago

I have the same issue with

ansible [core 2.14.10]
  python version = 3.11.5 (main, Aug 28 2023, 00:00:00) [GCC 13.2.1 20230728 (Red Hat 13.2.1-1)] (/usr/bin/python3)

and vyos.vyos collection 4.1.0