vyos / vyos.vyos

Ansible Network Collection for VyOS
GNU General Public License v3.0
69 stars 62 forks source link

[vyos_prefix_lists] Delete all prefix-lists failure #328

Closed brahmanim closed 9 months ago

brahmanim commented 1 year ago
SUMMARY

The Integration tests consistently failed on a task Delete all prefix-lists.

ISSUE TYPE
COMPONENT NAME

vyos_prefix_lists

ANSIBLE VERSION
2.15
COLLECTION VERSION
4.1.0
CONFIGURATION
None
OS / ENVIRONMENT
STEPS TO REPRODUCE

Run integration tests task Delete all prefix-lists

    # Delete all prefix-lists
    - name: Delete all prefix-lists
      register: result
      vyos.vyos.vyos_prefix_lists: &id006
        config:
        state: deleted
EXPECTED RESULTS

find specified prefix-list

ACTUAL RESULTS
TASK [/usr/share/ansible/collections/ansible_collections/vyos/vyos/tests/integration/targets/vyos_prefix_lists : Populate config] ***
task path: /usr/share/ansible/collections/ansible_collections/vyos/vyos/tests/integration/targets/vyos_prefix_lists/tests/cli/_populate_config.yaml:2
changed: [10.0.149.73] => {
    "changed": true,
    "commands": [
        "set policy prefix-list6 AllowIPv6Prefix description 'Configured by ansible for allowing IPv6 networks'",
        "set policy prefix-list6 AllowIPv6Prefix rule 5 action 'permit'",
        "set policy prefix-list6 AllowIPv6Prefix rule 5 description 'Permit rule'",
        "set policy prefix-list6 AllowIPv6Prefix rule 5 le '37'",
        "set policy prefix-list6 AllowIPv6Prefix rule 5 prefix '2001:db8:8000::/35'",
        "set policy prefix-list6 DenyIPv6Prefix description 'Configured by ansible for disallowing IPv6 networks'",
        "set policy prefix-list6 DenyIPv6Prefix rule 8 action 'deny'",
        "set policy prefix-list6 DenyIPv6Prefix rule 8 le '37'",
        "set policy prefix-list6 DenyIPv6Prefix rule 8 prefix '2001:db8:2000::/35'"
    ],
    "filtered": [],
    "invocation": {
        "module_args": {
            "backup": false,
            "backup_options": null,
            "comment": "configured by vyos_config",
            "config": null,
            "lines": [
                "set policy prefix-list AnsibleIPv4PrefixList description 'PL configured by ansible'",
                "set policy prefix-list AnsibleIPv4PrefixList rule 2 action 'permit'",
                "set policy prefix-list AnsibleIPv4PrefixList rule 2 description 'Rule 2 given by ansible'",
                "set policy prefix-list AnsibleIPv4PrefixList rule 2 le '32'",
                "set policy prefix-list AnsibleIPv4PrefixList rule 2 prefix '92.168.10.0/26'",
                "set policy prefix-list AnsibleIPv4PrefixList rule 3 action 'deny'",
                "set policy prefix-list AnsibleIPv4PrefixList rule 3 description 'Rule 3'",
                "set policy prefix-list AnsibleIPv4PrefixList rule 3 ge '26'",
                "set policy prefix-list AnsibleIPv4PrefixList rule 3 prefix '72.168.2.0/24'",
                "set policy prefix-list6 AllowIPv6Prefix description 'Configured by ansible for allowing IPv6 networks'",
                "set policy prefix-list6 AllowIPv6Prefix rule 5 action 'permit'",
                "set policy prefix-list6 AllowIPv6Prefix rule 5 description 'Permit rule'",
                "set policy prefix-list6 AllowIPv6Prefix rule 5 le '37'",
                "set policy prefix-list6 AllowIPv6Prefix rule 5 prefix '2001:db8:8000::/35'",
                "set policy prefix-list6 DenyIPv6Prefix description 'Configured by ansible for disallowing IPv6 networks'",
                "set policy prefix-list6 DenyIPv6Prefix rule 8 action 'deny'",
                "set policy prefix-list6 DenyIPv6Prefix rule 8 le '37'",
                "set policy prefix-list6 DenyIPv6Prefix rule 8 prefix '2001:db8:2000::/35'"
            ],
            "match": "line",
            "save": false,
            "src": null
        }
    }
}

TASK [/usr/share/ansible/collections/ansible_collections/vyos/vyos/tests/integration/targets/vyos_prefix_lists : Delete all prefix-lists] ***
task path: /usr/share/ansible/collections/ansible_collections/vyos/vyos/tests/integration/targets/vyos_prefix_lists/tests/cli/deleted.yaml:11
fatal: [10.0.149.73]: FAILED! => {
    "changed": false,
    "module_stderr": "commit failed: commit\\r\\n[ policy prefix-list AnsibleIPv4PrefixList rule 2 ]\\r\\n% Can't find specified prefix-list\\r\\n\\r\\ndelete [ policy prefix-list AnsibleIPv4PrefixList ] failed\\r\\nCommit failed\\r\\n[edit]\\r\\r\\nvyos@vyosTest# ",
    "module_stdout": "",
    "msg": "MODULE FAILURE\\nSee stdout/stderr for the exact error"
}
NilashishC commented 1 year ago

Maybe we just need to add ignore_errors: true to this since this is a cleanup task.