search

vyperlang / titanoboa

a vyper interpreter
https://titanoboa.readthedocs.io
Other
247 stars 49 forks source link

boa.test address strategy is not aligned with boa.env.generate_address() #112

Closed bout3fiddy closed 2 months ago

bout3fiddy commented 9 months ago

how boa.test generates addresses: https://github.com/vyperlang/titanoboa/blob/f879b3d35c1fb980aa61d18256a8638eb5b952c9/boa/test/strategies.py#L101

how boa.env generates addresses: https://github.com/vyperlang/titanoboa/blob/f879b3d35c1fb980aa61d18256a8638eb5b952c9/boa/environment.py#L579

unify these.

MukulKolpe commented 9 months ago

Hey @bout3fiddy, can I work on this issue?

charles-cooper commented 9 months ago

Hey @bout3fiddy, can I work on this issue?

go for it

charles-cooper commented 4 months ago

what's the issue here? boa.env.generate_address() is kind of deterministic

DanielSchiavini commented 3 months ago

if this is by design, can we close the issue?

charles-cooper commented 2 months ago

fixed, as of b6eacad8 the address strategy returns Address type