Sign typed data using BrowserSigner - Githubissues

vyperlang / titanoboa

a vyper interpreter

https://titanoboa.readthedocs.io

Other

247 stars 49 forks source link

Sign typed data using BrowserSigner #130

Closed DanielSchiavini closed 7 months ago

DanielSchiavini commented 7 months ago

Closes #128 ~~Depends on https://github.com/vyperlang/titanoboa/pull/124~~

What I did

Allow signing typed data using BrowserSigner

How I did it

Created the sign_typed_data method in the BrowserSigner.
Created the signTypedData front-end callback
Added a test

How to verify it

Try in a notebook:

!pip install git+https://github.com/DanielSchiavini/titanoboa.git@128/sign-typed-data
from boa.integrations.jupyter import BrowserSigner
BrowserSigner().sign_typed_data(....)

Description for the changelog

Allow signing typed data in JupyterLab/Colab using BrowserSigner

Cute Animal Picture

DanielSchiavini commented 7 months ago

@charles-cooper your comment is fixed in https://github.com/vyperlang/titanoboa/pull/131 There are no changes necessary in this branch, so I did not merge it here yet