vyperlang / titanoboa

a vyper interpreter
https://titanoboa.readthedocs.io
Other
247 stars 49 forks source link

Notify user of tx fail in boa call output #138

Closed bout3fiddy closed 2 months ago

bout3fiddy commented 7 months ago

Not sure how to do this but this tx to create a contract failed: https://bscscan.com/tx/0x77967045c0b62986ad3cf8933c746dff0b448dbffb2e71b89869e64ff54d1012

but boa returned an address (when nothing was deployed).

so there needs to be some sort of a check to tell the user that the tx failed

DanielSchiavini commented 7 months ago

eth_getTransactionReceipt returns a status (0/1) that we are not currently checking.

It's still weird that in your case eth_estimateGas returned the wrong amount.