fix: Improve Jupyter performance

DanielSchiavini commented 5 months ago

What I did

Improved the jupyter plugin performance considerably Fixed the empty elements while calling javascript

How I did it

Minified JS with command npx uglify-js --mangle -o jupyter.min.js -- jupyter.js
Instead of injecting the whole ethersJS library, just inline the wallet calls
Only inject the JS triggers once for JupyterLab - in colab this does not work

How to verify it

Jupyter plugin should keep on working but much better

Description for the changelog

Improved and simplified JupyterLab and Colab plugin

Cute Animal Picture

charles-cooper commented 5 months ago

i'm not convinced we want the complexity of introducing minification into the build process. fwiw after compression the minified version saves 900 bytes:

(boa) ~/titanoboa $ gzip -v < boa/integrations/jupyter/jupyter.js | wc
 61.7%
      6      47    1822
(boa) ~/titanoboa $ gzip -v < boa/integrations/jupyter/jupyter.min.js | wc
 47.0%
      3      19     949

charles-cooper commented 5 months ago

code review note: discussed refactoring the jupyter.js file into a full-on extension, but it seems to introduce more complexity than it is worth.

charles-cooper commented 5 months ago

just tested this -- works amazing! and it's deployed to try.vyperlang.org now :)

vyperlang / titanoboa