fix: lab view URL - Githubissues

vyperlang / titanoboa

a vyper interpreter

https://titanoboa.readthedocs.io

Other

242 stars 41 forks source link

fix: lab view URL #173

Closed DanielSchiavini closed 5 months ago

DanielSchiavini commented 5 months ago

What I did

Fixed callback URL when opening in lab view, i.e. https://try.vyperlang.org/user/{user}/lab/workspaces/auto-L/tree/{file}.ipynb instead of the notebook URL https://try.vyperlang.org/user/{user}/notebooks/{file}.ipynb

How I did it

Check if we are in lab view, if so recurse 3 directories
Added async to rpc so the exception is displayed properly

How to verify it

Open the notebook in the 2 views mentioned, it should work the same.

Description for the changelog

Fixed jupyter plugin lab view

Cute Animal Picture

charles-cooper commented 5 months ago

please fix some lint issue and then i can merge -- https://github.com/vyperlang/titanoboa/actions/runs/8051752665/job/21990356973?pr=173