search

vyperlang / titanoboa

a vyper interpreter
https://titanoboa.readthedocs.io
Other
242 stars 41 forks source link

wip - add requests_cache #189

Open charles-cooper opened 4 months ago

charles-cooper commented 4 months ago

What I did

How I did it

How to verify it

Description for the changelog

Cute Animal Picture

![Put a link to a cute animal picture inside the parenthesis-->]()

charles-cooper commented 4 months ago

this seems like a good feature to have but i'm not sure if we want to add dependencies willy-nilly. maybe we can add it as an extra? @DanielSchiavini

charles-cooper commented 4 months ago

it's mainly just useful for etherscan at this point, although theoretically it could also do caching for other web requests (like the RPC stuff).

we could also use the boa/utils/disk_cache.py thingy to implement caching by hand. so it's a tradeoff between reinventing stuff and adding dependencies. my concern about adding it as an extra is that the standard advice/setup will be "install boa with the requests_cache extra" and then it will be de facto the same as putting it in the required dependency list, but i'm not too sure on this one.