search

vyperlang / titanoboa

a vyper interpreter
https://titanoboa.readthedocs.io
Other
251 stars 49 forks source link

feat[test]: propagate dev reason to parent stack #207

Closed DanielSchiavini closed 5 months ago

DanielSchiavini commented 5 months ago

What I did

Fixed https://github.com/vyperlang/titanoboa/issues/199

How I did it

Copying dev reason to the parent error details

How to verify it

Test is included

Description for the changelog

dev reason is now propagated from child contracts so it may be used with boa.reverts

Cute Animal Picture

image

charles-cooper commented 5 months ago

yes, this looks nice. can we add a test for the case where both the caller and child lines have a dev reason? (the behavior in the code looks right -- the child should not stomp the parent reason -- but it will be good to have a test for it)