feat[logs]: read logs from ABI

vyperlang / titanoboa

a vyper interpreter

https://titanoboa.readthedocs.io

Other

251 stars 49 forks source link

feat[logs]: read logs from ABI #238

Closed DanielSchiavini closed 1 month ago

DanielSchiavini commented 4 months ago

What I did

Backported the ABI Log changes from the Vyper tests back to titanoboa.

How I did it

Implemented log parsing in the ABI contracts.

How to verify it

Tests are included

Description for the changelog

Support for parsing logs from the ABI definition

Cute Animal Picture

charles-cooper commented 4 months ago

hmm this is interesting, but how does it fit into boa workflow? typical boa workflow is to initialize an evm environment (local, fork or network) and then run tests against that. what is the workflow for this feature? maybe boa/chain_research.py?

charles-cooper commented 4 months ago

my other comment here is there is probably some amount of code overlap with the existing log parsing code, so we should try not to duplicate code if it makes sense to merge the code