search

vyperlang / vvm

Vyper version manager
MIT License
25 stars 9 forks source link

VVM should not use tqdm unless tqdm is installed #7

Closed sabotagebeats closed 3 years ago

sabotagebeats commented 3 years ago

https://github.com/vyperlang/vvm/blob/1c562ed481c62f706a3b70e2e55675874d23f623/vvm/install.py#L24-L27

iamdefinitelyahuman commented 3 years ago

tqdm is only required if vvm.install_vyper is called with the show_progress kwarg set to True. The docstring for this method states that when using show_progress you must have installed tqdm. In my mind this isn't an issue, as you can mitigate it by not requesting a progress bar or including tqdm as an upstream dependency.

fubuloubu commented 3 years ago

Makes sense!