vyperlang / vyper

Pythonic Smart Contract Language for the EVM
https://vyperlang.org
Other
4.83k stars 789 forks source link

fix[tool]: fix cross-compilation issues, add windows CI #4014

Closed charles-cooper closed 3 months ago

charles-cooper commented 3 months ago

What I did

How I did it

How to verify it

Commit message

this commit fixes some `InputBundle` bugs on windows due to how
path-manipulation operations are implemented. it also fixes compilation
of cross-OS archives by settling on using posix paths as standard (this
follows the ZIP archive spec, and is explicit in the python stdlib
implementation of zipfile).

this commit also enables a windows job in the CI for tests, to prevent
bugs like these in the future and increase cross-OS coverage.

references:
- https://stackoverflow.com/a/8177003
- https://hg.python.org/cpython/file/2.7/Lib/zipfile.py#l295
- https://hg.python.org/cpython/file/2.7/Lib/zipfile.py#l1046

Description for the changelog

Cute Animal Picture

![Put a link to a cute animal picture inside the parenthesis-->]()

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 50.29%. Comparing base (c276c94) to head (1afe87b).

:exclamation: Current head 1afe87b differs from pull request most recent head a43d2e8. Consider uploading reports for the commit a43d2e8 to get more accurate results

Files Patch % Lines
vyper/compiler/output_bundle.py 0.00% 7 Missing :warning:
vyper/cli/vyper_json.py 0.00% 2 Missing :warning:
vyper/compiler/input_bundle.py 33.33% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4014 +/- ## =========================================== - Coverage 90.95% 50.29% -40.67% =========================================== Files 106 106 Lines 15280 15282 +2 Branches 3365 3365 =========================================== - Hits 13898 7686 -6212 - Misses 946 6965 +6019 - Partials 436 631 +195 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.