search

vyperlang / vyper

Pythonic Smart Contract Language for the EVM
https://vyperlang.org
Other
4.85k stars 791 forks source link

fix[venom]: remove dominator tree invalidation for store elimination pass #4069

Closed harkal closed 4 months ago

harkal commented 4 months ago

What I did

Removed unnecessary dominator tree invalidation in StoreEliminations pass

How I did it

How to verify it

Commit message

Each pass has the responsibility of invalidating analyses that it affects according 
to the changes it introduces. 

The `StoreEliminationPass` should not invalidate the `DominatorTree`

Description for the changelog

Cute Animal Picture

![Put a link to a cute animal picture inside the parenthesis-->]()

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.70%. Comparing base (3371956) to head (9b3a2b5).

:exclamation: Current head 9b3a2b5 differs from pull request most recent head 76b4ba8

Please upload reports for the commit 76b4ba8 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4069 +/- ## ========================================== - Coverage 91.25% 88.70% -2.55% ========================================== Files 108 108 Lines 15522 15521 -1 Branches 3410 3410 ========================================== - Hits 14164 13768 -396 - Misses 926 1242 +316 - Partials 432 511 +79 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.