Closed charles-cooper closed 3 weeks ago
Attention: Patch coverage is 50.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 49.20%. Comparing base (
44bb281
) to head (f74024c
).:exclamation: Current head f74024c differs from pull request most recent head 0976fb5
Please upload reports for the commit 0976fb5 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
vyper/builtins/functions.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
i think that for the sake of completeness, we should also test with dirty memory
let's consider that a ptr points outside the buffer to a) dirty memory b) clean memory
we currently only test for b) and require that the spec matches the implementation
the spec should always raise when ptr points outside the buffer. but what if the implementation doesn't revert when pointing outside the buffer to dirty memory?
i think it's important to include structs - one of the original errors was incorrect validation of structs within dynarrays
i think it's important to include structs - one of the original errors was incorrect validation of structs within dynarrays
I mean structs share the same code path as tuples, but with named fields in the front-end. I don't think we are missing much by not including them
i think it's important to include structs - one of the original errors was incorrect validation of structs within dynarrays
I mean structs share the same code path as tuples, but with named fields in the front-end. I don't think we are missing much by not including them
we skip them for dynarrays, right?
i think it's important to include structs - one of the original errors was incorrect validation of structs within dynarrays
I mean structs share the same code path as tuples, but with named fields in the front-end. I don't think we are missing much by not including them
we skip them for dynarrays, right?
Ah right, those are disallowed by the language semantics. Ok let's add them
What I did
add a spec-based differential fuzzer test for
abi_decode
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture
![Put a link to a cute animal picture inside the parenthesis-->]()