vyperlang / vyper

Pythonic Smart Contract Language for the EVM
https://vyperlang.org
Other
4.81k stars 788 forks source link

fix[codegen]: add back in `returndatasize` check #4144

Closed charles-cooper closed 3 weeks ago

charles-cooper commented 3 weeks ago

it's not checked in make_setter when needs_clamp is False

What I did

How I did it

How to verify it

Commit message

add back in `returndatasize` check for external calls in the case
that `make_setter()` is not called (i.e. when `needs_clamp()` is
`True`). the check was removed (i.e. there was a regression) in
21f7172274e

test case and poc contributed by @cyberthirst

---------

Co-authored-by: cyberthirst <cyberthirst.eth@gmail.com>

Description for the changelog

Cute Animal Picture

![Put a link to a cute animal picture inside the parenthesis-->]()

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.38%. Comparing base (e9e9d78) to head (7653155).

:exclamation: Current head 7653155 differs from pull request most recent head e6cd05e

Please upload reports for the commit e6cd05e to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4144 +/- ## ========================================== - Coverage 91.20% 90.38% -0.82% ========================================== Files 109 109 Lines 15568 15552 -16 Branches 3417 3415 -2 ========================================== - Hits 14199 14057 -142 - Misses 939 1037 +98 - Partials 430 458 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.