vyperlang / vyper

Pythonic Smart Contract Language for the EVM
https://vyperlang.org
Other
4.83k stars 789 forks source link

chore[test]: fix a type hint #4173

Closed ZhipengXue97 closed 3 weeks ago

ZhipengXue97 commented 1 month ago

Description

Fix a type check warning reported by Pyre@Google, which was outdated after code modifications.

Detail

update the return type of function fix_terminal from bool to str, since it could be str after commit https://github.com/vyperlang/vyper/commit/176e7f7f3a6a16bc09ec58d4bbc8dc515c48a0a8

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.32%. Comparing base (5067b86) to head (5f470cb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4173 +/- ## ========================================== - Coverage 91.34% 88.32% -3.03% ========================================== Files 109 106 -3 Lines 15606 15247 -359 Branches 3432 3367 -65 ========================================== - Hits 14256 13467 -789 - Misses 920 1265 +345 - Partials 430 515 +85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

charles-cooper commented 1 month ago

interesting, thanks! @ZhipengXue97 are you performing large scale type hint fixes? https://github.com/ZhipengXue97?tab=overview&from=2024-07-01&to=2024-07-30

ZhipengXue97 commented 1 month ago

@charles-cooper We are trying to develop a tool to update the type hints based on the code modification such as commit, to avoid false positive warnings from type checker, this PR is fixed by our tool based on the previous commit.