Closed harkal closed 1 month ago
How do we get unnormalized code after algebraic optimizations?
Attention: Patch coverage is 10.00000%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 50.86%. Comparing base (
039d369
) to head (674b203
). Report is 1 commits behind head on master.
:exclamation: There is a different number of reports uploaded between BASE (039d369) and HEAD (674b203). Click for more details.
HEAD has 170 uploads less than BASE
| Flag | BASE (039d369) | HEAD (674b203) | |------|------|------| ||187|17|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
since MakeSSA is expensive, i think this solution works, but is not ideal. i'm ok with merging it as a kludge, but i think we want to leave a note to circle back and figure out why we are being taken out of ssa.
What I did
Resolve #4288 caused by unnormalised code after store elimination manipulating
phi
instructions. Added a test case for it.How I did it
Perform a
MakeSSA
pass after algebraic optimizationsHow to verify it
Commit message
Description for the changelog
Cute Animal Picture
![Put a link to a cute animal picture inside the parenthesis-->]()