vyperlang / vyper

Pythonic Smart Contract Language for the EVM
https://vyperlang.org
Other
4.91k stars 804 forks source link

refactor[venom]: update translator for `deploy` instruction #4318

Closed charles-cooper closed 1 month ago

charles-cooper commented 1 month ago

this commit updates ir_node_to_venom.py for the deploy instruction to properly emit the exit instruction. it also removes places in the translator where the exit instruction was improperly emitted.

misc:

What I did

fix #4317

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

![Put a link to a cute animal picture inside the parenthesis-->]()

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.21%. Comparing base (b3ea663) to head (16460d1). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
vyper/venom/function.py 42.85% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4318 +/- ## ========================================== - Coverage 91.40% 90.21% -1.20% ========================================== Files 112 112 Lines 15927 15927 Branches 2694 2693 -1 ========================================== - Hits 14558 14368 -190 - Misses 935 1093 +158 - Partials 434 466 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.