search

vyskoczilova / woocommerce-payforpayment

WordPress plugin WooCommerce Pay for Payment
13 stars 11 forks source link

Multi-currency doesn't work on gateway cost #43

Closed RomanHodulak closed 4 years ago

RomanHodulak commented 5 years ago

Hello, I'm using this plugin on a site with multiple languages and currencies. The problem is that the plugin does not convert the cost of the payment gateway (I'm using WooCommerce default COD gateway) nor the "cod - charges fixed" translation string. It only works with the [FIXED_AMOUNT] in the $fee_title, but not the actual cost (so if I set fixed cost to be "39", the COD is always 39, 39 Kč in CZ, 39 Ft in HU, 39 EUR etc.).

Can the fixed fee amount of a gateway be translated?

The site runs on WordPress 4.9.8 and I'm using these plugins: WooCommerce 3.5.1 WooCommerce Multilingual 4.3.7 WooCommerce Pay for Payment 2.0.10 WPML String Translation 2.8.5

vyskoczilova commented 5 years ago

Hi @RomanHodulak the fee should be translatable via string translation (I know this is not an ideal solution), could you check?

Karolina

RomanHodulak commented 5 years ago

Hi Karolina, thank you for a quick reaction. Looks like I've figured it out this morning but it's quite weird.

  1. I had to go to WPML String Translations -> Translate admin strings
  2. Click "woocommerce_cod_settings" and manually enable option "pay4pay_charges_fixed" screenshot_2018-11-28 string translation led light shoes - ledfashion top quality brand led light shoes wordpress
  3. A new translation string would pop out, this time it is called [woocommerce_cod_settings]pay4pay_charges_fixed. I've translated this string and this one actually works on frontend in the cart! screenshot_2018-11-28 string translation led light shoes - ledfashion top quality brand led light shoes wordpress 1

The weirdness is, that if I put the [FIXED_AMOUNT] string into the fee title translation string, it actually uses the cod - charges fixed to translate the fee cost. So there is different string for the fixed amount in the fee cost and the fee title.

For instance if I have cs set as a language on the website, and I set cs translations as:

In the cart it would show up as "Dobírka 39 Kč: 666 Kč".

vyskoczilova commented 5 years ago

Hi Roman, I see, thanks for providing detailed info. I will have a look and get back to you with a fix in the upcoming days (probably next week since I'm too busy at the moment).

stale[bot] commented 5 years ago

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for contributing :)

vyskoczilova commented 5 years ago

Howdy my dear bot, I'll have a look on it later, I promise.

Destabilizator commented 5 years ago

I've run into this issue as well, any ETA on fix?

Trick with translation is not applicable, as for English language I want to use fee in EUR and in USD, for Czech CZK.

stale[bot] commented 5 years ago

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for contributing :)

vyskoczilova commented 5 years ago

Howdy my dear bot, I'll have a look on it later, I promise. ¨

@Destabilizator I'll plan it for summer. There were some ongoing changes on WPML side and I wanted to wait for them. I'll keep you updated.

humblet commented 5 years ago

Also looking forward for fix, used the admin string at the moment 👍

vyskoczilova commented 5 years ago

Thanks, guys, I'm terribly busy, but keeping track on it. If you have time and could offer me a helping hand with a PR, I'm more than glad to review it :)

stale[bot] commented 5 years ago

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for contributing :)

vyskoczilova commented 5 years ago

I'll get back to it, I promise.

stale[bot] commented 4 years ago

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for contributing :)

vyskoczilova commented 4 years ago

I'll get back to it, I promise.

stale[bot] commented 4 years ago

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for contributing :)

vyskoczilova commented 4 years ago

I'll get back to it, I promise.

stale[bot] commented 4 years ago

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for contributing :)