Fix tax class selection in dropdown not updating #73

vyskoczilova / woocommerce-payforpayment

WordPress plugin WooCommerce Pay for Payment

13 stars 11 forks source link

Fix tax class selection in dropdown not updating #73 #74

Closed musilondrej closed 1 month ago

musilondrej commented 1 year ago

This pull request fixes an issue where users were unable to persistently select a tax class from the dropdown menu in the plugin settings. The selection would revert to the default option after saving due to a problem with how the tax class values were being handled.

Issue Related: This pull request refers to #73

I welcome any feedback on these changes and look forward to your review.

vyskoczilova commented 1 year ago

Hi Ondřej! Thanks a lot for the pull request and bug fix. I'll check it out on Friday/Monday (I'm OOO currently). I'll get back to you. Karolina

vyskoczilova commented 11 months ago

This is weird, I can't fix the bug you're mentioning in #74 https://www.loom.com/share/a2b46b1ae80d4517a11264c146be7749.

The proposed change is definitely worth implementing and I'll merge it, but I still wonder why the issue is not present on my end 🤔...?