vyuldashev / flysystem-curlftp

Flysystem Adapter for the FTP with cURL implementation
MIT License
36 stars 24 forks source link

Enable certification checking per default #17

Closed adrium closed 6 years ago

adrium commented 6 years ago

Enable certification checking should be enabled by default. Please note:

Users of this library should not be exposed to insecure behaviour. Since this library is published on Packagist with some popularity (> 100), I decided to write a pull request.

If necessary, the certificate checks could be disabled by the user by setting the connection options.

vyuldashev commented 6 years ago

Hi! Good point, but your PR just changes default values and does not give option to change these values.

adrium commented 6 years ago

Hi, I have never used this library and I do not intend to in the near future. I use another library for implicit FTPS. It also used insecure settings, see vendi-advertising/ftp_implicit_ssl#1.

your PR just changes default values and does not give option to change these values.

I rather just wanted to let you know, that the options in your library expose the users to insecure behaviour and I thinking fixing this should be high priority.

And maybe you already have an idea and would want to implement this in your own code style? Moreover, I thought it could be possible by doing something like:

$adapter->getConnection()->setOptions($options);
vyuldashev commented 6 years ago

Released v2.0.0 with secure options by default which can be changed. Credits @simoheinonen