search

vyuldashev / laravel-queue-rabbitmq

RabbitMQ driver for Laravel Queue. Supports Laravel Horizon.
MIT License
1.92k stars 377 forks source link

Laravel 7+ support. #337

Closed valehasadli closed 4 years ago

valehasadli commented 4 years ago

Hi @vyuldashev ! Are you planning to support Laravel7+? I think that you have a great job. It would be great for the community.

adm-bome commented 4 years ago

There is already support for 7+

adm-bome commented 4 years ago

@valehasadli For reference and for your concerns See

Just try it! And I think you can close your issue ;)

valehasadli commented 4 years ago

There is already support for 7+

I'm not sure, cause it needs review. I have tried brand new L7 project, it doesn't work before. Today I'll try again.

valehasadli commented 4 years ago

@valehasadli For reference and for your concerns See

Just try it! And I think you can close your issue ;)

I just closed, and it would be better transferred to another issue which you are mentioned.

adm-bome commented 4 years ago

You didn't have to close the issue, If you have an issue.

I want to know what the issue is realy about. As I said in the pull-request, i don't have issues in laravel 7.

The pull-request has changes in it that will break support for laravel/lumen 6.

And thats the main reason this pull-request is not approved yet.

If somebody can point out why? Why is this package not working for laravel 7? This would be helpfull