Installation issues on v3

vyuldashev / nova-permission

A Laravel Nova tool for Spatie's laravel-permission library

https://novapackages.com/packages/vyuldashev/nova-permission

419 stars 217 forks source link

Installation issues on v3 #163

Closed ale1981 closed 3 years ago

ale1981 commented 3 years ago

Laravel 8.41 Nova 3.25 Spatie 4.01

I have followed installation instructions but I am getting lots of errors, is this package compatible with the latest versions of Nova and Spatie?

After registering the tool I get the following error, am wondering if I have missed a step!

Type of Vyuldashev\NovaPermission\Role::$title must not be defined (as in class Laravel\Nova\Resource) {"userId":6,"e xception":"[object] (Symfony\Component\ErrorHandler\Error\FatalError(code: 0): Type of Vyuldashev\NovaPermission\Role::$title must not be defined (as in class Laravel\Nova\Resource) at /var/www/intranet/vendor/vyuldashev/nova-permission/src/Role.php:0)

Type of Vyuldashev\NovaPermission\Role::$search must not be defined (as in class Laravel\Nova\Resource) {"userId":6," exception":"[object] (Symfony\Component\ErrorHandler\Error\FatalError(code: 0): Type of Vyuldashev\NovaPermission\Role::$search must not be define d (as in class Laravel\Nova\Resource) at /var/www/intranet/vendor/vyuldashev/nova-permission/src/Role.php:0)

mustafaaloko commented 3 years ago

I faced this on my project as well. It's a single issue that will be thrown for multiple fields. It's on v3 only.

Downgrading to version 2.11 will solve this for now.

The cause is this commit: https://github.com/vyuldashev/nova-permission/commit/469fca9001422a08c4238b6dd04f4f29e56c61cd

@ale1981 can you please change the issue title to something like "Installation issue on v3" so it's more specific for others who come?

halberio commented 3 years ago

sirdharma commented 3 years ago

Hello,

We have the same issue.

Running laravel/nova version 3.26.1.

Thank you!

RVxLab commented 3 years ago

Also ran into this issue with Nova 3.22 on PHP 8.0. PR submitted to fix this issue, until then use my fork.

Add this to your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/rvxlab/nova-permission"
        }
    ]
}

Then reference dev-master as the version for vyuldashev/nova-permission:

{
    "require": {
        ...
        "vyuldashev/nova-permission": "dev-master"
    }
}

Run composer update vyuldashev/nova-permission and you should be good to go.

mrimran commented 3 years ago

Also ran into this issue with Nova 3.22 on PHP 8.0. PR submitted to fix this issue, until then use my fork.

Add this to your composer.json:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/rvxlab/nova-permission"
        }
    ]
}
Then reference dev-master as the version for vyuldashev/nova-permission:
{
    "require": {
        ...
        "vyuldashev/nova-permission": "dev-master"
    }
}
Run composer update vyuldashev/nova-permission and you should be good to go.

Why don't you submit pull request?

RVxLab commented 3 years ago

Also ran into this issue with Nova 3.22 on PHP 8.0. PR submitted to fix this issue, until then use my fork. Add this to your composer.json:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/rvxlab/nova-permission"
        }
    ]
}
Then reference dev-master as the version for vyuldashev/nova-permission:
{
    "require": {
        ...
        "vyuldashev/nova-permission": "dev-master"
    }
}
Run composer update vyuldashev/nova-permission and you should be good to go.
Why don't you submit pull request?

I did. Pretty sure vyuldashev only has to merge it at this point.