search

vyuldashev / nova-permission

A Laravel Nova tool for Spatie's laravel-permission library
https://novapackages.com/packages/vyuldashev/nova-permission
419 stars 217 forks source link

Fix incompatible types #164

Closed RVxLab closed 3 years ago

RVxLab commented 3 years ago

Remove type hints for fields as those are not compatible with Laravel\Nova\Resource

Remove type hints for RoleBooleanGroup::fillAttributeFromRequest as this isn't compatible with the base class

Fixes #163

RVxLab commented 3 years ago

I think you are missing RoleSelect here :) @RVxLab

Yep, looks like you're correct. I'll fix those when I get home later and go over other files where this may be an issue.

RVxLab commented 3 years ago

RoleSelect has also been changed and I double checked everything else. This should be good to go! :)

mrbenosborne commented 3 years ago

Can we merge this?

RVxLab commented 3 years ago

Pinging @vyuldashev as he probably doesn’t get notified otherwise (I’ve had this happen before).

If you could merge this that’s be grand as this package is actually unusable at this time.