search

vyznev / soup

Stack Overflow Unofficial Patch
27 stars 6 forks source link

SOUP is breaking Enter keyboard shortcut for comments #28

Closed JeffreyMercado closed 8 years ago

JeffreyMercado commented 8 years ago

It seems SOUP is affecting the comment boxes breaking the Enter key. With it enabled, pressing Enter to submit or edit a comment doesn't work, nothing happens. Disabling fixes the issue.

Perhaps a fix similar to the one for http://meta.stackexchange.com/a/285035 is needed. Michael mentions something about changes to the :visible selector.

SOUP 1.45.22 (via Tampermonkey 4.1.10) Stack Overflow rev 2016.10.5.4036 Win 7 SP1 Chrome 53.0.2785.143

vyznev commented 8 years ago

Are you sure this still happens with SOUP 1.45.22? Versions up to 1.45.20 indeed had this bug, but it should be fixed now, and I can't reproduce it on SOUP 1.45.22 / Chromium 52.0.2743.116.

JeffreyMercado commented 8 years ago

I will double check the versions tomorrow. That was from my work machine. Trying again at home also didn't work, but I'm not on the latest versions it seems. Forcing updates only gets me 1.44.4 on Chrome and FF. I have a feeling I took the wrong numbers.

vyznev commented 8 years ago

SOUP 1.44.4 is the latest stable release (as of yesterday), and should also have the fix. Looks like you have the stable branch of SOUP installed on your home browsers, and the unstable development branch installed at work.

JeffreyMercado commented 8 years ago

Ok, from my work machine, I'm definitely on 1.45.22. But it's working fine now. I'm not sure what happened. I was sure to update everything and force refreshing of SO. Sorry, nothing to see here.