search

vyznev / soup

Stack Overflow Unofficial Patch
27 stars 6 forks source link

Small space is added between comments and timestamps #30

Closed Sir-Cumference closed 5 years ago

Sir-Cumference commented 7 years ago

Small bug, but I thought I'd mention it. Normally, the comments look like this:

screen shot 2017-08-03 at 1 37 14 pm

However SOUP adds an extra space between the comment and the dash:

screen shot 2017-08-03 at 1 37 04 pm

This causes the timestamps to shift a bit when the page loads.

vyznev commented 7 years ago

Thanks for the report!

The extra space is actually a deliberate feature, to make the signature stand off just a little bit from the comment text. But you've got a point that the shifting can be a bit distracting too. I probably should either remove the extra space or find a way to eliminate the delay before the fix is applied.

In any case, that fix apparently doesn't do what it's primarily meant to do (i.e. prevent wrapping between the dash and the signature) consistently on all browsers, so I really need to revisit it anyway in some upcoming SOUP version.

vyznev commented 5 years ago

This should be fixed in SOUP 1.54. While tweaking the fix to make it work correctly on Chrome, I decided to simply remove the extra space to avoid any unnecessary layout jumps.